Fix a build issue related to Qt dll files. #798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+This issue only became a fatal error when I moved the vs2019 build environment to cmake-3.17. There was a `POST_BUILD` command that copied Qt dll files to the unit test build directory, but the command was malformed. The issue is fixed. +I also removed some complicated logic from `component_macros.cmake` that was also related to copying dll file to the unit test binary directories. It doesn't appear that this logic is required with the new tools.
KineticTheory
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #798 +/- ##
=========================================
+ Coverage 94.0% 94.1% +0.1%
=========================================
Files 367 364 -3
Lines 17219 17072 -147
=========================================
- Hits 16187 16070 -117
+ Misses 1032 1002 -30 |
KineticTheory
changed the title
|
@keadyk This is ready for review and merge. It is almost entirely the removal of code that was once required but that cmake now handles automatically. |
|
LGTM! Merging now. :) |
KineticTheory
added a commit
to KineticTheory/Draco
that referenced
this pull request
Apr 15, 2020
…ed dlls. + After lanl#798, the build system no longer copied the eospac or compton dll to the build tree. When these files are missing at run time, the tests will fail. + TPLs provided by the vcpkg package manager know how to install themselves into the build tree. This is what allowed the simplifications found in lanl#798 to work. However, eospac and compton are not currently provided by vcpkg, so they must be copied via `POST_BUILD` rules. + This PR fixes issue lanl#802
6 tasks
KineticTheory
added a commit
that referenced
this pull request
Apr 15, 2020
…ed dlls. (#803) + After #798, the build system no longer copied the eospac or compton dll to the build tree. When these files are missing at run time, the tests will fail. + TPLs provided by the vcpkg package manager know how to install themselves into the build tree. This is what allowed the simplifications found in #798 to work. However, eospac and compton are not currently provided by vcpkg, so they must be copied via `POST_BUILD` rules. + This PR fixes issue #802
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
POST_BUILDcommand that copied Qt dll files to the unit test build directory, but the command was malformed. The issue is fixed.component_macros.cmakethat was also related to copying dll file to the unit test binary directories. It doesn't appear that this logic is required with the new tools.Status